zhengruifeng commented on code in PR #59162:
URL: https://github.com/apache/spark/pull/59162#discussion_r4254401026
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/FrequentItems.scala:
##########
@@ -88,6 +88,21 @@ case class CollectFrequentItems(
override def createAggregationBuffer(): mutable.Map[Any, Long] =
mutable.Map.empty[Any, Long]
+ /**
+ * Returns the map key for `value`. A BinaryType value is wrapped in a
[[BinaryKey]] so that the
Review Comment:
how is this case handled in other collect-like expressionsl like
'collectset'?
are the approaches consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
