cloud-fan commented on PR #58760:
URL: https://github.com/apache/spark/pull/58760#issuecomment-6140257363
I re-reviewed the current commit. The repeated-position, retained-state, and
plan-ID changes are supported by the current analyzer paths and coverage. One
issue remains: the new hidden/visible merge is quadratic for wide schemas,
including existing qualified-star queries above wide USING/NATURAL joins.
Please linearize that merge; there is also a one-word counterfactual tense fix
in the new ScalaDoc.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6096127671","thread_id":"conversation:6096127671","verdict_sha256":"8b246c7040b28ea5a9f8e0ff3a2cc21e5d414018d91fb7f48e8a984fc0ba1f4b"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
