uros-b commented on code in PR #59399:
URL: https://github.com/apache/spark/pull/59399#discussion_r4258084585
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/ResolverGuard.scala:
##########
@@ -762,8 +755,6 @@ object ResolverGuard {
private val UNSUPPORTED_FUNCTION_NAMES = {
val map = new IdentifierMap[Unit]()
// User info functions are not supported.
- // [[InlineUserInfoExpressions]] cannot be invoked as a post-hoc rule as
it produces
- // inconsistent aliases based on the table type (because of the rule
ordering in fixed-point).
map += ("current_user", ())
map += ("session_user", ())
Review Comment:
Is there a missed leftover below (783-784)?
The `HIGHER_ORDER_FUNCTIONS` scaladoc says these functions are "supported
but guarded under the
`ANALYZER_SINGLE_PASS_RESOLVER_ENABLE_HIGHER_ORDER_FUNCTIONS_RESOLUTION` flag".
That flag is not in SQLConf, and `isUnsupportedFunction` (681-685) rejects
every HOF unconditionally. Suggested text: "Higher order functions that are not
yet supported by the single-pass resolver."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
