rdtr commented on PR #59425: URL: https://github.com/apache/spark/pull/59425#issuecomment-6152067810
@sarutak Thank you for the detailed review! - Lint: fixed in 3921af28e9. scalafmt only rewrapped one doc comment in `SparkConnectPlanner`. `dev/lint-scala` passes locally. - Description: I updated all four points. The blocklist sentence now says it rejects any `Command` plus a few side-effecting plans that are not `Command` subclasses, the reference case now points to `executeSQLWithRefs` running each reference with `Dataset.ofRows`, the headings use `###`, and the opening line about #56241 is removed. - The top-node limitation: agreed that it is out of scope here. I'd like to fix it as a follow-up after this PR, by checking the whole parsed plan. I'll open a JIRA for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
