HyukjinKwon commented on code in PR #59247:
URL: https://github.com/apache/spark/pull/59247#discussion_r4263088983


##########
python/pyspark/sql/streaming/listener.py:
##########
@@ -583,6 +588,15 @@ def batchDuration(self) -> int:
         """
         return self["batchDuration"]
 
+    @property
+    def trigger(self) -> Optional[Dict[str, Any]]:
+        """
+        The configured trigger type and options, or ``None`` when unavailable.
+
+        .. versionadded:: 5.0.0

Review Comment:
   **Nit (P3):** This is master's version. Under the repo's versioning policy 
(AGENTS.md, "Versioning and Branch Policy"), an additive change opened against 
master ships first in `branch-4.x` (currently 4.4.0-SNAPSHOT). As written, the 
PySpark 4.4 docs would say the property first appeared in 5.0.0. Other new 
PySpark APIs on this base already use 4.4.0.
   
   ```suggestion
           .. versionadded:: 4.4.0
   ```
   
   **Verification:**
   - **Inspection:** The version annotation on the new trigger property matches 
the branch-4.x release version (4.4.0), and the changed module has no 
`versionadded:: 5.0.0`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to