mihailoale-db commented on code in PR #59267:
URL: https://github.com/apache/spark/pull/59267#discussion_r4273353797
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/AsOfJoinResolver.scala:
##########
@@ -216,8 +275,8 @@ class AsOfJoinResolver(
val rightOperand = resolveExpressionInJoin(unresolvedAsOfJoin,
unresolvedRightOperand)
AsOfJoinMatchConditionResolution.materialize(
join = partiallyResolved,
- leftSet = AttributeSet(leftNameScope.output),
- rightSet = AttributeSet(rightNameScope.output),
+ leftSet = AttributeSet(leftNameScope.output ++
leftNameScope.hiddenOutput),
Review Comment:
Something seems off here. Here we use `hiddenOutput` whereas below we use
`metadataOutput`. These are not the same. Which one is correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
