vb-dbrks commented on PR #59408: URL: https://github.com/apache/spark/pull/59408#issuecomment-6189717784
@HyukjinKwon thank you for checking this. I've pushed a new commit, adding `.setScale(0)` before constructing the intermediate `Decimal` in the negative-scale branch. The rounded value is already integral, so this avoids that configuration lookup while preserving result values, types and ANSI overflow handling. I also expanded the existing carry and runtime overflow tests to cover both legacy negative-scale settings, alongside both ANSI modes and interpreted/generated execution. The PR description now explains why Float widening is retained, separates the latest validation from earlier runs, and links to the current PR checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
