dongjoon-hyun commented on PR #597: URL: https://github.com/apache/spark-connect-swift/pull/597#issuecomment-6222779818
Thank you for the thorough review, @viirya. I addressed the comments in fefb833: - Added `DataFrameTests.resultChunking` (gated on Spark 4.1+). It sets `spark.connect.session.resultChunking.maxChunkSize` to 1024 to force chunking and checks `collect()`, `count()` and `isEmpty()`. - `execute()` now throws `InvalidArrowData` if the stream ends with an incomplete chunked batch. - Added the note about `maxRequestMessageBytes` and `maxResponseMessageBytes`, simplified the chunk concatenation, relaxed the test assertion and fixed the typo. `preferred_arrow_chunk_size` for a smaller `grpc_max_message_size` will be handled in a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
