dongjoon-hyun commented on PR #599:
URL:
https://github.com/apache/spark-connect-swift/pull/599#issuecomment-6224572620
Thanks for the approval and the careful review!
- Yes, I also tried it with `returnType` omitted: I registered the same
`UDF2` jar without a return type, so the server had to infer it, and `SELECT
sconcat2('x', 'y')` returned `xy`. You are right that the earlier description
only mentioned `.string`, so I updated it to cover both cases.
- "How was this patch tested?" now lists `registerJavaWithUnknownClass` and
`registerJavaWithoutUDFInterface`.
- The `#require(throws:)` nit is addressed in b355e84.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
