gengliangwang commented on code in PR #58755:
URL: https://github.com/apache/spark/pull/58755#discussion_r4299741301
##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -307,6 +307,10 @@ trait Logging {
log.isTraceEnabled
}
+ protected def withLogLevel(level: Slf4jLevel)(f: => Unit): Unit = {
Review Comment:
**[P2] Keep the log-level guard out of the shared Logging trait**
Adding this method generates a public forwarder in serializable `Logging`
implementations, changing `UDTRegistration$`'s computed `serialVersionUID` from
`-3417430582631602433` to `-3728152430189732578`. This exactly matches the
existing `UdfSerializationSuite` CI failure. Spark Connect payloads from
released 4.1/4.2 clients that capture `UDTRegistration` now fail with
`InvalidClassException`; the audited 4.0 compatibility transition also stops
matching because `UdfSerialization` requires the exact producer/consumer UID
pair. Keep the guard directly in `PlanChangeLogger`, or use a private helper
there, to preserve serialization compatibility. Updating only the existing
transition's local UID would still miss the newly necessary transitions from
4.1/4.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
