Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6714#discussion_r32702243
  
    --- Diff: python/pyspark/tests.py ---
    @@ -179,9 +179,12 @@ def test_in_memory_sort(self):
                              list(sorter.sorted(l, key=lambda x: -x, 
reverse=True)))
     
         def test_external_sort(self):
    +        class CustomizedSorter(ExternalSorter):
    +            def _next_limit(self):
    --- End diff --
    
    It seems like the intent here is to mock `get_used_memory()`; I'm not super 
familiar with Python mocking frameworks, but if this was Java then I imagine 
that `get_used_memory()` would be a method of some context / environment object 
that we could mock.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to