viirya commented on PR #59565: URL: https://github.com/apache/spark/pull/59565#issuecomment-6230361400
Thank you for the detailed review, @dongjoon-hyun. I addressed the inline comments in a13f6569487. On the description: you're right that the NPE / internal error can't surface, since `end()` replaces it with `ClosedByInterruptException`. I changed it to list only the native outcomes, a JVM crash or silent memory corruption, and updated how the buffer is freed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
