cloud-fan commented on PR #58144:
URL: https://github.com/apache/spark/pull/58144#issuecomment-6263721624
Thanks for the update. I rechecked the head: the derived-cut swap, the
cascade-aware merge check, the IN/NOT pin, the between-link rename and
bounded-fallback tests, and the wide-output ordering are in. Three of these
items still leave a related gap, which I left as inline comments on
Optimizer.scala. First, the conservative pin also fires for rank conjuncts that
can never become a group limit, such as rn > 1, which can cost an exchange
compared with flag-off. Second, the rejected-chain fallback still swaps a
pinned rank window down, although the overview says pinned top windows are
exempt. Third, the wide-tier group order is not a one-pass fixed point when a
narrow window can ride both a wide and a narrow group.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6249199754","thread_id":"conversation:6249199754","verdict_sha256":"9eacac3df4bbaeba9d0fbfadc984cbe263d55c0bf10ec30b85c8e5ffb9043166"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
