Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6859#issuecomment-113054457
Well, the JVM will often use `StringBuilder` anyway for certain string
concatenations. I think this may make memory usage _worse_ as you hold on to
references to large strings, but also intermediate copies of some
concatenations. Certainly, the received wisdom in Java is to _use_
`StringBuilder` in this case, not the opposite.
Did you actually hit a problem here or profile the change? I would suggest
it's not a great use of time to try to optimize things that aren't known to be
a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
