dongjoon-hyun commented on PR #59571:
URL: https://github.com/apache/spark/pull/59571#issuecomment-6269036009

   > `TimeTypeApiOps.toSQLValue` (sql/api/.../types/ops/TimeTypeApiOps.scala) 
still renders `TIME '${format(v)}'` with trailing zeros stripped, so it now 
disagrees with `Literal.sql` for TIME(7)-TIME(9).
   
   Thank you for the review, @MaxGekk. `TypeApiOps.toSQLValue` has no 
production caller yet, and `TimestampNanosTypeApiOps.toSQLValue` already has 
the same gap with `Literal.sql` for the nanosecond timestamps (SPARK-57339 pads 
only in `Literal.sql`). To keep this blocker fix narrow, let me align both ops 
with `Literal.sql` in a new JIRA issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to