sweb commented on PR #58010: URL: https://github.com/apache/spark/pull/58010#issuecomment-6271957397
> The escaping and the new substitution sentence look good. The PR description hasn't caught up with [ae1664f](https://github.com/apache/spark/commit/ae1664f2d2ad87f4f8c512f864c3365600177965) yet, and it becomes the commit message: What changes could say that injected values are written with `$` doubled because Kubernetes expands `$(VAR)` and `$$` in env values; the `BasicExecutorFeatureStepSuite` list is missing `SSL RPC passwords are escaped for Kubernetes env var expansion`; and the user-facing sentence on variable substitution could say that both the referenced variable and the matching `_SPARK_SSL_RPC_*` variable have to be bound on the executors. Thank you for pointing this out! I added this part to the first paragraph: ``` The values are written with `$` doubled, because Kubernetes expands `$(VAR)` and `$$` in `EnvVar.value`. After expansion the executor reads the exact password. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
