cloud-fan commented on PR #56969:
URL: https://github.com/apache/spark/pull/56969#issuecomment-6287745373
Thanks @uros-b. Yes, I have a concern. `inputTypes` now accepts microsecond
TIMESTAMP_NTZ without a cast, and `zoneIdForType(date1.dataType)` is applied to
both operands. Because of that, existing queries that pair TIMESTAMP_NTZ with
TIMESTAMP_LTZ, DATE, or a string now return different, argument-order-dependent
results in non-UTC sessions; I left details on `datetimeExpressions.scala`.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6280010132","thread_id":"conversation:6280010132","verdict_sha256":"a3a33db908a32f07a974527a060a65a70e4f3e4bc6880dca6e0e1cab5b93928f"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
