Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6872#discussion_r32703641
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -154,6 +156,220 @@ case class Cos(child: Expression) extends
UnaryMathExpression(math.cos, "COS")
case class Cosh(child: Expression) extends UnaryMathExpression(math.cosh,
"COSH")
+// This logic is borrowed from hive
+class ConvUtil {
--- End diff --
I think you should rewrite this part in a more functional way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
