dongjoon-hyun commented on PR #59641: URL: https://github.com/apache/spark/pull/59641#issuecomment-6294371977
Thank you for the review, @MaxGekk . Here is the summary of my replies. - [Keeping the sound predicates](https://github.com/apache/spark/pull/59641#discussion_r4326481644) and [the generic precision hook](https://github.com/apache/spark/pull/59641#discussion_r4326481656): I'd like to keep this PR minimal as a correctness fix for `branch-4.3` too. I'll recover the pushdown by rewriting the bounds, and revisit the hook, in a new JIRA issue for both `TIME` and `TIMESTAMP(NANOS)`. - [The redundant loop](https://github.com/apache/spark/pull/59641#discussion_r4326481669) and [the read precision 8](https://github.com/apache/spark/pull/59641#discussion_r4326481692): Updated. - [The V2 coverage](https://github.com/apache/spark/pull/59641#discussion_r4326481680): No change, because `ParquetFilterSuite` runs as both `ParquetV1FilterSuite` and `ParquetV2FilterSuite`. - ORC: I confirmed that ORC has the same issue. I'll consider it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
