Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32703910
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +314,40 @@ final class ShuffleBlockFetcherIterator(
}
}
+/**
+ * Helper class that ensures a ManagedBuffer is release upon
InputStream.close()
+ * Note: the delegate parameter is private[storage] to make it available
to tests.
+ */
+private class BufferReleasingInputStream(
+ private[storage] val delegate: InputStream,
+ iterator: ShuffleBlockFetcherIterator)
+ extends InputStream {
+ private var closed = false
--- End diff --
can we mark this as private[this]?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
