MaxGekk commented on PR #59573: URL: https://github.com/apache/spark/pull/59573#issuecomment-6308891202
Thanks @dongjoon-hyun, the PR description is updated for items 14 and 15. I merged master to resolve the conflict in `WholeStageCodegenSuite` with the SPARK-60403 tests; the suite passes locally with both sets of tests. @cloud-fan @LuciferYang your threads are answered in 1fce024 and f81f1c8: the preceding checks are placed in the order of the condition after a nullable conjunct, the nested check on an expression stays at its position, and the flag and the hoisting are generated only when a conjunct or check can raise. Could you take another look? If there are no further comments, I plan to merge once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
