szehon-ho commented on code in PR #59036: URL: https://github.com/apache/spark/pull/59036#discussion_r4342390323
########## docs/sql-ref-syntax-aux-show-tblproperties.md: ########## @@ -24,6 +24,11 @@ license: | This statement returns the value of a table property given an optional value for a property key. If no key is specified then all the properties are returned. +For V2 tables, the output may also include display-only properties supplied by the catalog. +`ALTER TABLE ... UNSET TBLPROPERTIES` does not remove these entries, and `SHOW CREATE TABLE` Review Comment: Updated both SQL reference pages in 7a571495923 to distinguish Spark's behavior from the catalog's: Spark itself does not remove display-only entries on UNSET, whether they remain depends on the catalog, and a display value appears after unsetting a stored key only if the catalog still supplies it. ########## docs/sql-ref-syntax-aux-show-tblproperties.md: ########## @@ -24,6 +24,11 @@ license: | This statement returns the value of a table property given an optional value for a property key. If no key is specified then all the properties are returned. +For V2 tables, the output may also include display-only properties supplied by the catalog. +`ALTER TABLE ... UNSET TBLPROPERTIES` does not remove these entries, and `SHOW CREATE TABLE` +does not include them. Stored properties take precedence over display-only entries with the +same key; unsetting a stored non-reserved property exposes the display-only value if present. Review Comment: Updated both pages in 7a571495923 to say "other than comment" instead of "non-reserved", and explicitly state that display-only comment entries are ignored even after unsetting the stored comment. ########## docs/sql-ref-syntax-aux-show-tblproperties.md: ########## @@ -24,6 +24,11 @@ license: | This statement returns the value of a table property given an optional value for a property key. If no key is specified then all the properties are returned. +For V2 tables, the output may also include display-only properties supplied by the catalog. Review Comment: Updated both pages in 7a571495923 to use "For tables in Data Source V2 catalogs" with a link to the existing Data Source V2 page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
