holdenk commented on code in PR #59060:
URL: https://github.com/apache/spark/pull/59060#discussion_r4342544874
##########
python/pyspark/sql/transpile.py:
##########
@@ -238,7 +241,8 @@ class CatalystTranspiler(AbstractTranspiler):
variety = "catalyst"
- def __init__(self) -> None:
+ def __init__(self, null_strictness: str = "strict") -> None:
+ self._null_strictness = null_strictness
Review Comment:
nit:
I think we could simplify the logic by just having
```
null_strictness = (
session.conf.get("spark.sql.experimental.optimizer.transpileNullStrictness",
"strict")
or "strict"
)
``` here instead of passing it in as a class param, the tests would need to
change to mutate the session conf object so I could go either way on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
