ctagard commented on code in PR #59403:
URL: https://github.com/apache/spark/pull/59403#discussion_r4342760420
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala:
##########
@@ -100,6 +103,68 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
// Scaladoc just above.
}
+ /**
+ * Whether `aggregate` outputs its float/double grouping keys normalized.
The planner normalizes
+ * the grouping keys of every Aggregate (see `SparkStrategies.Aggregation`),
except one whose
+ * aggregate functions are all grouped-agg pandas UDFs, planned as
`ArrowAggregatePythonExec` on
+ * the raw keys. Rules that replace an Aggregate with a Project check
[[readsNormalizedKeys]].
Review Comment:
I would love to tackle it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
