holdenk commented on code in PR #58365:
URL: https://github.com/apache/spark/pull/58365#discussion_r4342856887
##########
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala:
##########
@@ -485,6 +485,7 @@ private[spark] object CoarseGrainedExecutorBackend extends
Logging {
driverConf.set(EXECUTOR_ID, arguments.executorId)
cfg.logLevel.foreach(logLevel => Utils.setLogLevelIfNeeded(logLevel))
+ Utils.setLoggerLevels(driverConf)
Review Comment:
The executor path for applying per-logger log levels is not covered by any
tests. Please add a test to verify that these configurations are correctly
applied when running on an executor.
---
<sub>Generated with assistance of franktheunicorn</sub>
<!-- franktheunicorn-managed -->
<!-- franktheunicorn-attempt:df6e8e7ec6154a2792266ad8913aa022:269 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
