szehon-ho commented on code in PR #59683: URL: https://github.com/apache/spark/pull/59683#discussion_r4343368165
########## docs/sql-v2-data-sources.md: ########## @@ -280,9 +289,31 @@ for mix-in interfaces. The pushdown order is: 5. **Offset** (`SupportsPushDownOffset`) 6. **Column pruning** (`SupportsPushDownRequiredColumns`) -Each mix-in interface has a method that Spark calls with the relevant operators. The -implementation returns the operators it can handle, and Spark applies the remaining operators -itself. +Each mix-in has a method that Spark calls with the candidate operator, and the return value tells +Spark what it must still evaluate itself after the scan: + +- [`SupportsPushDownFilters`](api/java/org/apache/spark/sql/connector/read/SupportsPushDownFilters.html): Review Comment: Note: we could add the other mixins too then (can be another pr) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
