dongjoon-hyun opened a new pull request, #619: URL: https://github.com/apache/spark-connect-swift/pull/619
### What changes were proposed in this pull request? This PR aims to remove the following unused files, which were copied from the `ArrowFlight` module of Apache Arrow Swift 19.0.1 by SPARK-51465. - `Flight.pb.swift`: generated from Arrow Flight's `Flight.proto` - `FlightData.swift`: `public class FlightData` - `FlightDescriptor.swift`: `public class FlightDescriptor` In addition, `AGENTS.md` no longer lists `Flight.pb.swift` as generated code. ### Why are the changes needed? Spark Connect doesn't use Arrow Flight. The server sends query results as serialized Arrow data in [ExecutePlanResponse.ArrowBatch](https://github.com/apache/spark/blob/v4.2.0/sql/connect/common/src/main/protobuf/spark/connect/base.proto#L453-L469) of `v4.2.0` (2026-07-11), and `DataFrame` reads it with `ArrowReader`. The three files only refer to each other, and no source, test, or example has ever used them. Only 3 of the 19 files in [ArrowFlight](https://github.com/apache/arrow/tree/apache-arrow-19.0.1/swift/ArrowFlight/Sources/ArrowFlight) of `apache-arrow-19.0.1` (2025-02-16) were copied, so there is no Flight client or server to use them with. The other vendored files come from the `Arrow` module, which doesn't depend on `ArrowFlight`. In addition, `Flight.pb.swift` was generated by an old version of the SwiftProtobuf plugin and causes all 20 warnings of the library build. ``` Sources/SparkConnect/Flight.pb.swift:639:58: warning: 'init(dictionaryLiteral:)' is deprecated: Please regenerate your .pb.swift files with the current version of the SwiftProtobuf protoc plugin. [#DeprecatedDeclaration] ``` ### Does this PR introduce _any_ user-facing change? Yes. This removes two `public` classes, `FlightData` and `FlightDescriptor` (including `FlightDescriptor.DescriptorType`), so code that refers to them doesn't compile anymore. They have been `public` since [v0.1.0](https://github.com/apache/spark-connect-swift/releases/tag/v0.1.0) (2025-05-08) and are in the latest release, [0.7.0](https://github.com/apache/spark-connect-swift/releases/tag/0.7.0) (2026-07-25). However, SPARK-51997 hid them from the documentation with `@nodoc`, and no other API takes or returns them. There is no behavior change. ### How was this patch tested? Pass the CIs. In addition, I checked that a clean build of the library has no warnings instead of 20, and that all tests pass against an `apache/spark:4.2.0` Connect server. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
