dtenedor commented on code in PR #59665: URL: https://github.com/apache/spark/pull/59665#discussion_r4351716948
########## sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala: ########## @@ -93,6 +107,14 @@ import org.apache.spark.util.Utils * To inspect the DataFrame interactively, set a breakpoint in `runDebugQueries` at the * line where `localSparkSession.sql(sql)` is called, then evaluate the DataFrame in the * debugger (e.g., `df.queryExecution.analyzed`, `df.explain(true)`). + * 7. CREATE FLOW registers a named flow definition without running it. REFRESH FLOW runs the Review Comment: As mentioned offline, this is adding a lot of complexity into `SQLQueryTestSuite.scala`; can we please instead make a subclass of for this purpose with the new functionality inside? This can provide better encapsulation of the code and help future readers understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
