Github user zhichao-li commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r32707498
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -426,3 +426,68 @@ case class MinOf(left: Expression, right: Expression)
extends BinaryArithmetic {
override def toString: String = s"MinOf($left, $right)"
}
+
+case class Pmod(left: Expression, right: Expression) extends
BinaryArithmetic {
+
+ override def symbol: String = "pmod"
+
+ override def toString: String = s"pmod($left, $right)"
+
+ protected def checkTypesInternal(t: DataType) =
+ TypeUtils.checkForNumericExpr(t, "pmod")
+
+ override lazy val resolved =
+ childrenResolved && checkInputDataTypes().isSuccess &&
!DecimalType.isFixed(dataType)
+
+ protected override def evalInternal(left: Any, right: Any) =
+ dataType match {
+ case IntegerType => pmod(left.asInstanceOf[Integer],
right.asInstanceOf[Integer])
+ case LongType => pmod(left.asInstanceOf[Long],
right.asInstanceOf[Long])
+ case ShortType => pmod(left.asInstanceOf[Short],
right.asInstanceOf[Short])
+ case ByteType => pmod(left.asInstanceOf[Byte],
right.asInstanceOf[Byte])
+ case FloatType => pmod(left.asInstanceOf[Float],
right.asInstanceOf[Float])
+ case DoubleType => pmod(left.asInstanceOf[Double],
right.asInstanceOf[Double])
+ case _: DecimalType => pmod(left.asInstanceOf[Decimal],
right.asInstanceOf[Decimal])
--- End diff --
Good idea , but seems like the clac result would be a little bit different
with the expected result. `pmod(7.2, 4.1), actual: 3.099999999999999, expected:
3.1000000000000005` . I'm keen on keeping it this way if not obvious downside.
``` scala
private lazy val integral = dataType match {
case i: IntegralType => i.integral.asInstanceOf[Integral[Any]]
case i: FractionalType => i.asIntegral.asInstanceOf[Integral[Any]]
case i: DecimalType => i.asIntegral.asInstanceOf[Integral[Any]]
}
protected override def evalInternal(a: Any, n: Any) =
integral.rem(integral.plus(integral.rem(a, n), n), n)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
