szehon-ho commented on code in PR #59732:
URL: https://github.com/apache/spark/pull/59732#discussion_r4355134308


##########
docs/sql-migration-guide.md:
##########
@@ -24,6 +24,7 @@ license: |
 
 ## Upgrading from Spark SQL 4.4 to 5.0
 
+- Since Spark 5.0, Data Source V2 file scans preserve filters containing 
deterministic Python UDFs on partition columns for evaluation after the scan. 
Previously, these filters could be dropped, returning rows that did not satisfy 
the filter (SPARK-60486). Affected queries can now return fewer rows; data 
derived from their previous results may need to be recomputed.

Review Comment:
   we should probably get this in sooner.  and also how about make it a bit 
more user-friendly (from preserve filters to correctly evaluate)
   
   ```
   Since Spark 4.4, Data Source V2 file scans correctly evaluate deterministic 
Python UDF filter predicates that reference only partition columns. Previously, 
these predicates could be dropped, returning rows that did not satisfy the 
filter (SPARK-60486). Data derived from affected query results may need to be 
recomputed.
   ```



##########
docs/sql-migration-guide.md:
##########
@@ -24,6 +24,7 @@ license: |
 
 ## Upgrading from Spark SQL 4.4 to 5.0
 
+- Since Spark 5.0, Data Source V2 file scans preserve filters containing 
deterministic Python UDFs on partition columns for evaluation after the scan. 
Previously, these filters could be dropped, returning rows that did not satisfy 
the filter (SPARK-60486). Affected queries can now return fewer rows; data 
derived from their previous results may need to be recomputed.

Review Comment:
   we should probably get this in sooner than spark 5.  and also how about make 
it a bit more user-friendly (from preserve filters to correctly evaluate)
   
   ```
   Since Spark 4.4, Data Source V2 file scans correctly evaluate deterministic 
Python UDF filter predicates that reference only partition columns. Previously, 
these predicates could be dropped, returning rows that did not satisfy the 
filter (SPARK-60486). Data derived from affected query results may need to be 
recomputed.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to