spark-test commented on code in PR #59746: URL: https://github.com/apache/spark/pull/59746#discussion_r4358819247
########## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ViewCommandHelper.scala: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.catalyst.plans.logical.{DropView, LogicalPlan} +import org.apache.spark.sql.connector.catalog.ViewCatalog +import org.apache.spark.sql.errors.QueryCompilationErrors +import org.apache.spark.sql.execution.command.{DropTableCommand, DropTempViewCommand} + +/** + * Rewrites resolved view commands to their session-catalog commands in [[ResolveSessionCatalog]]. + * Views in a [[ViewCatalog]] keep the V2 command. + */ +object ViewCommandHelper { + + /** + * Rewrites a resolved [[DropView]] to [[DropTempViewCommand]] for a temporary view or to + * [[DropTableCommand]] for a session-catalog view. Fails for a session-catalog target whose + * namespace does not have exactly one part, and for a catalog that cannot host views. Returns + * `dropView` itself if its target is in a [[ViewCatalog]] or is not resolved. Review Comment: **Nit (P3):** This sentence, and the object-level one at line 27 ("Views in a [[ViewCatalog]] keep the V2 command."), promise that any `ViewCatalog` target is returned unchanged. The case order below does not do that for the session catalog. `DropViewInSessionCatalog` (line 42) matches first, and its guard is `CatalogV2Util.isSessionCatalog`, which only compares the catalog name. So if `spark.sql.catalog.spark_catalog` is a `CatalogExtension` that also implements `ViewCatalog` (or `RelationCatalog`), `DROP VIEW spark_catalog.db.v` still becomes `DropTableCommand(isView = true)`, or hits the namespace errors, and never reaches `DataSourceV2Strategy` / `ViewCatalog.dropView`. The behavior itself matches the merge base. Only the new helper-level contract overstates it. Since this helper is meant to be reused, e.g. by the single-pass resolver, a caller reading this doc would expect the wrong route. Qualifying both sentences as "non-session `ViewCatalog`" would match the inline comment below ("Other non-session catalogs") and the `DataSourceV2Strategy` comment ("DROP VIEW on a non-session ViewCatalog"). **Verification:** - **Inspection:** Check that both ViewCommandHelper scaladoc sentences about ViewCatalog routing are qualified as non-session, and that together they describe rewrite's case order (temporary view, then session catalog, then non-ViewCatalog or system catalog, then unchanged) without claiming that a session catalog implementing ViewCatalog keeps the V2 command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
