ohad-definity commented on code in PR #59706: URL: https://github.com/apache/spark/pull/59706#discussion_r4361635590
########## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningThroughGenerateSuite.scala: ########## @@ -0,0 +1,883 @@ +/* Review Comment: Added a paragraph on the suite to "How was this patch tested?", crediting you and the Taboola cases. ########## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SchemaPruningThroughGenerateSuite.scala: ########## @@ -0,0 +1,883 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with Review Comment: Added in 11a1fbbd: "size() rewritten in a generator chain with ANSI mode on" in `SchemaPruningSuite` covers a non-outer chain (scan schema + rows) and `size(item.parts)` over an outer chain, compared against the flag-off rows and asserting a null size is present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
