stevomitric commented on code in PR #58946:
URL: https://github.com/apache/spark/pull/58946#discussion_r4368081308
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala:
##########
@@ -1047,6 +1048,13 @@ object CatalogColumnStat extends Logging {
case TimestampType => getTimestampFormatter(isParsing = true).parse(s)
case TimestampNTZType =>
getTimestampFormatter(isParsing = true, forTimestampNTZ =
true).parse(s)
+ case t: TimestampLTZNanosType =>
Review Comment:
what would happen if someone sets `spark.sql.legacy.timeParserPolicy=LEGACY`
?
Will the old formater throw an exception?
##########
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala:
##########
@@ -642,6 +642,128 @@ class StatisticsCollectionSuite extends
StatisticsCollectionTestBase with Shared
}
}
+ test("SPARK-57812: describe column stats (min, max) for nanosecond timestamp
columns") {
+ withDefaultTimeZone(UTC) {
Review Comment:
maybe add some non-utc timezones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
