dbtsai commented on PR #102: URL: https://github.com/apache/spark-connect-rust/pull/102#issuecomment-6431287318
Thanks for the review. Addressed the feedback in [ff6fddd](https://github.com/apache/spark-connect-rust/commit/ff6fddd3afce376895c802a5a0a113105060a1e8): added common expression constructors, removed the two redundant expression boxes, trimmed/consolidated sharing tests, and added the Rust 4.3 migration note in `docs/compatibility.md`. I also shortened the description while retaining the benchmark caveats. The unrelated docs-checker CI changes have been extracted and are kept in a local follow-up. Validation: 424 Rust tests passed; all core integration targets compiled with and without `wasm-udf`; the native Python extension built in release mode; all 52 Rust documentation snippets type-checked. A before/after snapshot of the 108 exported native classes found no changed members or text signatures. Formatting and diff checks passed. Live-server/official parity suites and benchmarks were not rerun for this cleanup. Workspace Clippy is blocked locally by the missing WASM target, and focused core/binding Clippy still reports existing lint failures, as recorded in the updated description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
