stevomitric commented on code in PR #59785:
URL: https://github.com/apache/spark/pull/59785#discussion_r4390860275
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionHelper.scala:
##########
@@ -429,7 +429,9 @@ abstract class TypeCoercionHelper {
* microsecond grid (a DayTimeIntervalType in the default mode, a
CalendarIntervalType when
* spark.sql.legacy.interval.enabled is set), so widening the precision
never changes the numeric
* result -- it only keeps the two operands the same concrete type. For a
pure-micro cross-family
- * pair this returns TimestampNTZType, identical to the pre-nanos behavior.
+ * pair this returns TimestampNTZType, identical to the pre-nanos behavior.
A nanos operand only
+ * survives analysis in the as-of join distance;
[[NanosTimestampSubtractionCheck]] rejects it
+ * anywhere else.
Review Comment:
fixed, running NanosTimestampSubtractionCheck.checkExpression as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
