dbtsai opened a new pull request, #104: URL: https://github.com/apache/spark-connect-rust/pull/104
### What changes were proposed in this pull request? Follow up on [the review of #102](https://github.com/apache/spark-connect-rust/pull/102#pullrequestreview-5672008601) for [SPARK-60549](https://issues.apache.org/jira/browse/SPARK-60549). Replace exact `Arc::strong_count` assertions in `related_builders_share_the_source_plan` with direct `LogicalPlan` pointer comparisons. Cover both batch writers, the streaming writer, the merge writer, `TableArg`, and its clone. Four crate-private accessors, compiled only for tests, expose the builders' plan references. ### Why are the changes needed? An extra `Arc` handle can break an exact-count assertion even when every builder still shares the original plan. Pointer comparisons directly check that each builder retains the source allocation and reject separately allocated copies. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - `cargo fmt --all --check` passed. - 392 release-mode Rust tests passed: 368 library tests and 24 expression-sharing/golden integration tests. - All core integration targets compiled in release mode, both with and without `wasm-udf`. - Five CI-tooling tests passed. - Workspace Clippy was blocked by the locally unavailable `wasm32-unknown-unknown` target. A core-only Clippy run reached existing `clippy::approx_constant` errors in unchanged tests; neither Clippy run passed. - The live-server and full official parity suites were not rerun for this test-only change. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-6) This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
