Github user EugenCepoi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5708#discussion_r32719064
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -926,7 +926,9 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
         // The call to new NewHadoopJob automatically adds security 
credentials to conf,
         // so we don't need to explicitly add them ourselves
         val job = new NewHadoopJob(conf)
    -    NewFileInputFormat.addInputPath(job, new Path(path))
    +    // Use addInputPaths so that newAPIHadoopFile aligns with hadoopFile 
in taking
    +    // comma separated files as input. (see SPARK-7155)
    +    NewFileInputFormat.addInputPaths(job, path)
    --- End diff --
    
    Yes but originally to support multiple paths one would achieve it by adding 
them directly to the config. Code that was relying on it breaks (my case :() 
though it's easy to fix. In practice I am not sure there is any real advantage 
in preventing people to add paths from some code outside spark. WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to