sarutak commented on code in PR #59878:
URL: https://github.com/apache/spark/pull/59878#discussion_r4406696669
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -313,8 +313,12 @@ private[spark] class SparkSubmit extends Logging {
case (YARN, CLUSTER) if isConnectServer(args.mainClass) =>
logInfo("SparkConnectServer is starting in cluster deploy mode. " +
"Use `yarn application -kill` command or YARN client API to stop the
server.")
+ case (KUBERNETES, CLUSTER) if isConnectServer(args.mainClass) =>
+ logInfo("SparkConnectServer is starting in cluster deploy mode. " +
+ "Use `kubectl delete` command to delete the driver pod to stop the
server.")
Review Comment:
With `spark.kubernetes.submission.waitAppCompletion=false` and
`sbin/start-connect-server.sh`, the launcher exits soon after creating the pod,
so `spark-daemon.sh` may report "failed to launch" even though the pod was
created. Also, `sbin/stop-connect-server.sh` cannot stop the server whether or
not this is set, because it only kills the local launcher process. The message
(or the docs) should probably say to stop the server with `spark-submit --kill`
rather than `stop-connect-server.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
