naveenp2708 commented on PR #59789: URL: https://github.com/apache/spark/pull/59789#issuecomment-6505722282
Thanks @peter-toth, all in 063555657ec. On 1 — redid the description. It describes the DataSourceV2Strategy gate and the three shapes now, not the old second-param-list version, and the user-facing answer is “Yes” with the before/after. Also dropped the line about streaming scans reading the live config, that’s not how it works anymore. On 4 — you’re right, exists was passing on master off the purchases scan in shapes 1 and 2. Now it grabs the scan DPP actually rebuilds (the one with runtime filters) and asserts forall over those, so it’s pinning the rebuilt scan every time. Confirmed it fails on master in all three shapes. 10 and 11 are the comment/scaladoc fixes — DSv2PlanMergingSuite now points at DataSourceV2Strategy, and the scaladoc lists all three reasons for None (no key, key can’t be resolved / nothing survives pruning, or SPJ off). CI’s green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
