dongjoon-hyun commented on code in PR #59895:
URL: https://github.com/apache/spark/pull/59895#discussion_r4417588408
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/GroupBasedMergeIntoTableSuite.scala:
##########
@@ -82,6 +82,58 @@ class GroupBasedMergeIntoTableSuite extends
MergeIntoTableSuiteBase {
}
}
+ test("SPARK-60667: merge with type coercion handles metadata columns
correctly") {
Review Comment:
Thank you. You're right. In 749b293e38a, I added `SPARK-60667: insert-only
merge with type coercion handles metadata columns correctly` to
`MergeIntoTableSuiteBase`, next to the SPARK-60708 insert-only test, so that it
runs in all group-based and delta-based `MERGE` suites. It runs your example
and checks the result. It also checks that the write schema of the append has
only the data columns, reading it from `InsertOnlyMergeExec` like the
SPARK-58007 insert-only test. Without this fix, it fails in every suite with
`No assignment for 'index'` and `No assignment for '_partition'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
