srielau commented on PR #59868: URL: https://github.com/apache/spark/pull/59868#issuecomment-6505429697
Follow-up on the remaining nits in the last review, landed in debac86ae83: - Later-line caret tests, invalid `stopIndex` / empty fragment, `sqlTextSlice`, scripting `getText`, pipeline origin after an emoji comment, and whole-text origin mapping after substitution. - Public `QueryContext` javadoc and PySpark docstrings name the code-point unit and inclusive stop. - parse_sql no longer re-slices in-range fragments. On recounting statement start/length: I would keep the current implementation. Carrying offsets from the splitter is a larger change than this bugfix, and the extra counts are linear and small next to ANTLR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
