hzmsh commented on PR #59558: URL: https://github.com/apache/spark/pull/59558#issuecomment-6512023109
Thanks @gaogaotiantian, and sorry that my earlier comment was confusing! 1. The SCALAR merge was only meant as a possible answer to your questions about the ignores and the ~200 lines. If you're OK with how the overloads look now, I think it's better to leave them as they are, rather than loosen type checking just to trim lines. 2. I've removed the test from `test_udf.yml` in dbe5edd, as you suggested. Thank you for the guidance and for taking the time to review this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
