spark-test commented on PR #59882:
URL: https://github.com/apache/spark/pull/59882#issuecomment-6512337674
Thanks for the update. I rechecked af30df7 at the current head: the
self-comparison is gone. The constant-folding test now asserts `foldable`
directly for the literal-input expression and both fresh copies. It also checks
that `ConstantFolding` turns each into `Literal.create(expected,
expression.dataType)`, and that the attribute-input versions stay non-foldable
and unchanged. That resolves the earlier foldability nit.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6485179745","thread_id":"conversation:6485179745","verdict_sha256":"0edece192d3872d11c6494070bff9754ecc730fa4df56681d5f17774597da5fa"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
