ohad-definity commented on PR #59706: URL: https://github.com/apache/spark/pull/59706#issuecomment-6500843155
@peter-toth thanks for the thorough review and for running the extra shapes. All findings are addressed (replies inline): - 1 (blocking): fresh-builder fallback per your points in b5869812, with a narrow-only builder test. - 2: pinned as a follow-up for now. - 3–8: fd44a39d. 6 (the stale `TODO(SPARK-34956)` in `GeneratorNestedColumnAliasing`) now notes that multiple fields are pruned at the scan by `SchemaPruning`. The description's notes for reviewers are updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
