mhatipog commented on PR #59529: URL: https://github.com/apache/spark/pull/59529#issuecomment-6494892118
> Thanks for flagging the overlap, @mhatipog. I checked #59445 — your PR landed the narrowed `hasCorrelatedSubquery` / `hasInOrCorrelatedExistsSubquery` guard before mine, and the fix is functionally identical. Happy to defer to yours as the primary. > > One thing I noticed: the end-to-end tests in #59445 cover correlated scalar and EXISTS but not IN (`ListQuery`) subqueries through LIMIT. I have a test case for that in this PR — happy to open a small follow-up PR against your branch adding it, or you can grab it from here. Let me know what works. > > I'll close this PR once #59445 is on track to merge. Nice work on the fix. Thanks @txwyy123, really appreciate you spotting the missing end-to-end IN coverage and offering to help! I added a projected IN regression case to #59445 earlier today (27c65ec), covering both LIMIT and OFFSET, so it looks like we've converged on the same test. Thanks also for digging into the Filter vs Project distinction. Happy to coordinate any remaining improvements. Appreciate the collaboration! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
