gaogaotiantian commented on code in PR #59355:
URL: https://github.com/apache/spark/pull/59355#discussion_r4418884247
##########
python/pyspark/sql/connect/session.py:
##########
@@ -835,9 +835,9 @@ def createDataFrame(
max_batch_of_chunks_size_bytes,
)
- df = DataFrame(plan, self)
+ df: ParentDataFrame = DataFrame(plan, self)
Review Comment:
I don't believe this is really correct. Let's revert this.
##########
python/pyspark/sql/connect/tvf.py:
##########
@@ -37,10 +38,8 @@ def range(
end: Optional[int] = None,
step: int = 1,
numPartitions: Optional[int] = None,
- ) -> "DataFrame":
- return self._sparkSession.range( # type: ignore[return-value]
- start, end, step, numPartitions
- )
+ ) -> "ParentDataFrame":
Review Comment:
This might be incorrect too. Let's avoid the `DataFrame` related stuff for
now unless you fully understand what happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
