cloud-fan commented on PR #59027:
URL: https://github.com/apache/spark/pull/59027#issuecomment-6514980325
Thanks for the update. I checked the listed changes at this head, and they
are all in place: the BuildLeft candidate counts, the output-row metric cases,
the per-key-family boundaries in the config doc, the direct key evaluation in
the builders, the interpreted inner-join iterator, the stream-reuse regression
test, the boxed inclusive scans, the new staggered benchmark rows, and the
comment and fixture fixes. The three planner trade-offs are now documented.
Whether documentation alone is enough for them is covered in this review's
Decision challenges section.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6393891668","thread_id":"conversation:6393891668","verdict_sha256":"925ae67fb431e0e1fcaf21fbfdd41ab4fc8e59ee6488dbe31ae7f29ca8e6a9ec"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
