surawut-jirasaktavee commented on PR #59422: URL: https://github.com/apache/spark/pull/59422#issuecomment-6518210523
@HyukjinKwon Thanks for the review. I pushed the fix for the binding policy comment: `spark.sql.legacy.regexpInstrIgnoreGroupIndex` now uses `ConfigBindingPolicy.SESSION`, and a new test in `StringFunctionsSuite` checks that a persisted view follows the session value of the flag. I also updated the PR description. CI on the latest commit ([run](https://github.com/surawut-jirasaktavee/spark/actions/runs/41007701401)): `hive - other tests` now passes, along with the `sql` jobs. Two jobs still fail, and neither comes from this change: - `pyspark-connect-old-client`: the expected branch-4.0 `regexp_instr` doctest mismatch. It will pass once #59465 is merged. - `Run TPC-DS queries with SF=1`: tpcds-kit fails to compile on the new `ubuntu-26.04` runner image (`-Wimplicit-int` error in `date.c`), before any Spark code runs. Could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
