HyukjinKwon commented on PR #59925: URL: https://github.com/apache/spark/pull/59925#issuecomment-6521737015
Thank you, @dongjoon-hyun. Done in bb41e00 for items 1 to 4: 1. The `connect` group of `pyproject.toml` requires `grpcio>=1.84.1` and `grpcio-status>=1.84.1`, as `setup.py`, `dev/requirements.txt` and `install.rst` do. 2. `internal_ci_connect` pins `grpcio==1.84.1` and `grpcio-status==1.84.1`, so the images that install `ci_connect_standard`, `ci_connect_minimum`, `ci_lint` and `ci_docs` get them. 3. `ci_connect_pandas_3` pins them too. 4. With item 2, `python-minimum/Dockerfile` installs 1.84.1 through `ci_connect_minimum`, so the minimum-version job covers the new minimum. `build_infra_images_cache.yml` already rebuilds the images when `pyproject.toml` changes. The pins of `internal_ci_connect` resolve together. The PR description now lists `pyproject.toml`. For item 5, I'd keep the runtime checks out of this PR and handle them in a separate JIRA. `require_minimum_grpc_version()` checks the version that the client needs to import and run (`googleapis-common-protos` is also checked at 1.56.4, while `setup.py` requires 1.71.0). Raising it to 1.84.1 would make `pyspark.sql.connect` fail to import, rather than fail to install, in an environment that pins an older grpcio. That behavior change deserves its own discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
