vladanvasi-db opened a new pull request, #59959:
URL: https://github.com/apache/spark/pull/59959
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'common/utils/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Extract shared CREATE VIEW analysis helpers without changing SQL behavior:
- Move session-catalog lowering into `ViewCommandHelper.rewriteCreateView`;
non-session targets retain their V2 command.
- Expose `ApplyDefaultCollation.resolveCreateViewCollation`, preserving
explicit collations, origin, tags, and the existing metadata-lookup failure
behavior.
- Move temporary-variable dependency collectors into `IdentifierResolution`,
preserving root expressions, nested subqueries, plan children, and distinct
variable names.
- Add `CatalogIdentifierResolution.resolveUnresolvedIdentifier` for command
targets without column output, preserving origin and tags, and use it in
`ResolveCatalogs`.
Jira: [SPARK-60748](https://issues.apache.org/jira/browse/SPARK-60748).
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
These operations are currently embedded in fixed-point analyzer rules.
Sharing the targeted operations allows command resolution and IDENTIFIER
preprocessing to reuse the existing implementation rather than invoke whole
rules or duplicate behavior. This is preparation only; it does not enable new
single-pass analyzer coverage.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No. Existing command lowering, default-collation selection,
variable-dependency collection, and catalog routing are preserved.
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Added focused Catalyst tests for root-variable and subquery dependency
collection, distinct names, plan children, identifier origin/tags, and
temporary-view routing.
Passed with Java 17:
```text
build/sbt 'catalyst/testOnly
org.apache.spark.sql.catalyst.analysis.AnalysisSuite -- -z "collect temporary
variables"'
build/sbt 'catalyst/testOnly
org.apache.spark.sql.catalyst.analysis.CatalogSuite'
build/sbt 'sql/testOnly
org.apache.spark.sql.execution.command.v1.CreateViewSuite
org.apache.spark.sql.execution.command.v2.CreateViewSuite'
build/sbt 'sql/testOnly
org.apache.spark.sql.collation.DefaultCollationStringTestSuiteV1
org.apache.spark.sql.collation.DefaultCollationStringTestSuiteV2 -- -z "CREATE
VIEW with schema level collation"'
```
These runs passed 46 tests: one variable-collection test, four catalog
tests, 28 CREATE VIEW tests, and 13 schema-level collation cases. The V2
collation suite has no tests matching this filter; V2 explicit-collation
behavior is covered by `execution.command.v2.CreateViewSuite`.
The following style checks also passed with no errors or warnings:
```text
build/sbt catalyst/Compile/scalastyle catalyst/Test/scalastyle
sql/Compile/scalastyle sql/Test/scalastyle
```
`git diff --check` passed.
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex CLI 0.165.0
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
